add new task       

Task ID:  6188  Pond updates    
 
Created by peter.devoil on 2016-10-17 10:04 AM, 671 days ago
Project:  Module Code
Category:  Bug
Priority:  [no priority]
Assigned to:  [not assigned]  
Status:  closed
Apsim Version:
Your Name:
Contact Details:
 
 

show inline images      show change history

 comment 42483 posted by peter.devoil on 2016-10-17 4:50 PM, 671 days ago 

fixed in r3990

 comment 42479 posted by peter.devoil on 2016-10-17 10:04 AM, 671 days ago 

Updates from don:

I found and fixed a small unexpected problem in Pond.f90.  Could you also please update the tip version Pond.f90, with the attached one?  The changes required to fix the problem involved making a local subroutine integer variable into a global one.  It used to work previously as a local one, but doesn’t anymore.  Not sure why???  But the attached file fixes the problem and will work.

 

I also made some earlier changes to Pond.f90 which I hadn’t got around to submitting into version control. They allow more than one rice crop to be active in a simulation at the same time (for example, one crop nearing maturity in the main field, one in the nursery ready for transplanting when other one finished).  They are also included in the attached Pond.f90 and I would appreciate if you could incorporate these improvements at the same time.  The attached Pond.f90 is from APSIM77, so any general code changes to current tip version are not included.